github workflow: enable workflow approval #632
Conversation
| - labeled | ||
| - synchronize | ||
| branches: | ||
| - main |
There was a problem hiding this comment.
Note: there is no main branch in bbolt, instead it's master.
There was a problem hiding this comment.
Perhaps in future we should align the branch to main @ahrtr? I believe the procedure is pretty straightforward in GitHub. It makes sense to try and use same across all sig-etcd subprojects if possible I think.
There was a problem hiding this comment.
I can leave both main and master in the meantime, let me know what you think. So, when we rename the branch to main there's not gonna be a dependency here.
There was a problem hiding this comment.
Perhaps in future we should align the branch to main
OK, let me do it on weekend.
There was a problem hiding this comment.
cc @jmhbnz @serathius @wenjiaswe @fuweid @tjungblu @Elbehery
If there is no any objection, I will rename the master to main on weekend.
Reference: https://www.git-tower.com/learn/git/faq/git-rename-master-to-main
There was a problem hiding this comment.
You can also do it easily from the GitHub repository settings page (ref: https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-branches-in-your-repository/changing-the-default-branch)
If it's fine with you, I'll revert my last change and set the branch name to main, and you can merge after you have renamed the main branch ✌️
ivanvc
force-pushed
the
enable-github-workflow-approval-via-ok-to-test-label
branch
from
17e15d5 to
13d4d08
Compare
Allow to run GitHub workflows for Pull Requests that have the ok-to-test label. Signed-off-by: Ivan Valdes <[email protected]>
ivanvc
force-pushed
the
enable-github-workflow-approval-via-ok-to-test-label
branch
from
13d4d08 to
bdf8eea
Compare
|
@ivanvc could you please submit a new PR? The PR is automatically closed after I renamed the master to main. |
Allow to run GitHub workflows for Pull Requests that have the ok-to-test label.
Fixes #631